Builtins fixed

The builtins wasnt protected, now all data received is protected, the hashmap addition is protected and added functionality of env, export and unset (not implemented in this version). Added fixed details documentation in docs/builtins_fixes.md generated by codex and created tests/builtins_edge_cases.sh to test all the builtins to work correctly

src/builtins/builtins.c

@@ -12,23 +12,53 @@
 
 #include "builtins.h"
 
-u_int8_t	set_builtins(
-	t_minishell *minishell
-) {
-	minishell->builtins
-		= ft_hashmap_new(4, ft_hashmap_hashstr, ft_hashmap_strcmp);
-	if (minishell->builtins == NULL)
+static uint8_t	register_builtin(
+	t_minishell *minishell,
+	const char *name,
+	t_builtin_func builtin
+)
+{
+	char	*key;
+
+	key = ft_strdup(name);
+	if (key == NULL)
 		return (0);
-	ft_hashmap_put(minishell->builtins, ft_strdup("cd"), builtin_cd);
-	ft_hashmap_put(minishell->builtins, ft_strdup("echo"), builtin_echo);
-	ft_hashmap_put(minishell->builtins, ft_strdup("exit"), builtin_exit);
-	ft_hashmap_put(minishell->builtins, ft_strdup("pwd"), builtin_pwd);
+	ft_hashmap_put(minishell->builtins, key, builtin);
+	if (!ft_hashmap_contains_key(minishell->builtins, name))
+	{
+		free(key);
+		return (0);
+	}
 	return (1);
 }
 
-u_int8_t	is_builtin(
+uint8_t	set_builtins(
+	t_minishell *minishell
+) {
+	minishell->builtins
+		= ft_hashmap_new(7, ft_hashmap_hashstr, ft_hashmap_strcmp);
+	if (minishell->builtins == NULL)
+		return (0);
+	if (!register_builtin(minishell, "cd", builtin_cd)
+		|| !register_builtin(minishell, "echo", builtin_echo)
+		|| !register_builtin(minishell, "env", builtin_env)
+		|| !register_builtin(minishell, "exit", builtin_exit)
+		|| !register_builtin(minishell, "export", builtin_export)
+		|| !register_builtin(minishell, "pwd", builtin_pwd)
+		|| !register_builtin(minishell, "unset", builtin_unset))
+	{
+		ft_hashmap_clear_keys(&minishell->builtins);
+		return (0);
+	}
+	return (1);
+}
+
+uint8_t	is_builtin(
 	const char *command_name,
 	t_minishell *minishell
 ) {
+	if (command_name == NULL || minishell == NULL
+		|| minishell->builtins == NULL)
+		return (0);
 	return (ft_hashmap_contains_key(minishell->builtins, command_name));
 }

src/builtins/cd/cd.c

@@ -12,43 +12,104 @@
 
 #include "builtins.h"
 
-static u_int8_t	handle_error(t_command cmd, t_minishell *msh, char *path);
+static uint8_t	handle_error(void);
+static void		update_pwd_vars(t_minishell *msh, char *oldpwd);
+static char		*get_path_from_env(
+					t_minishell *msh,
+					const char *env_name,
+					const char *error,
+					uint8_t *status
+					);
+static char		*resolve_cd_path(
+					t_command cmd,
+					t_minishell *msh,
+					uint8_t *status
+					);
 
-u_int8_t	builtin_cd(
+uint8_t	builtin_cd(
 	t_command cmd,
 	t_minishell *msh
 ){
 	char	*path;
+	char	*oldpwd;
+	uint8_t	status;
+	bool	show_pwd;
 
-	if (cmd.argc > 2)
-	{
-		ft_eputendl("minishell: cd: too many arguments");
-		return (2);
-	}
-	else if (cmd.argc == 1)
-		path = get_env("HOME", msh);
-	else
-		path = cmd.argv[1];
+	path = resolve_cd_path(cmd, msh, &status);
+	if (status != EXIT_SUCCESS)
+		return (status);
+	show_pwd = (cmd.argc == 2 && ft_strcmp(cmd.argv[1], "-") == 0);
+	oldpwd = getcwd(NULL, 0);
 	if (chdir(path) == -1)
-		return (handle_error(cmd, msh, path));
+	{
+		free(oldpwd);
+		return (handle_error());
+	}
+	update_pwd_vars(msh, oldpwd);
+	if (show_pwd && get_env("PWD", msh) != NULL)
+		ft_putendl(get_env("PWD", msh));
+	free(oldpwd);
 	return (EXIT_SUCCESS);
 }
 
-static u_int8_t	handle_error(
+static uint8_t	handle_error(void)
+{
+	perror("minishell: cd");
+	return (EXIT_FAILURE);
+}
+
+static void	update_pwd_vars(
+	t_minishell *msh,
+	char *oldpwd
+){
+	char	*newpwd;
+
+	if (oldpwd != NULL)
+		set_env("OLDPWD", oldpwd, msh);
+	newpwd = getcwd(NULL, 0);
+	if (newpwd != NULL)
+	{
+		set_env("PWD", newpwd, msh);
+		free(newpwd);
+	}
+}
+
+static char	*resolve_cd_path(
 	t_command cmd,
 	t_minishell *msh,
-	char *path
+	uint8_t *status
 ){
-	u_int8_t	exit_code;
-
-	(void)msh;
-	exit_code = 0;
-	if (access(path, F_OK) != -1)
-		// No such file or directory
-		exit_code = 1;
-	else if (access(path, X_OK) == -1)
-		// Permission denied
-		exit_code = 2;
-	perror(cmd.argv[0]);
-	return (exit_code);
+	if (cmd.argc > 2)
+	{
+		ft_eputendl("minishell: cd: too many arguments");
+		*status = EXIT_FAILURE;
+		return (NULL);
+	}
+	if (cmd.argc == 2 && ft_strcmp(cmd.argv[1], "-") == 0)
+		return (get_path_from_env(msh, "OLDPWD",
+				"minishell: cd: OLDPWD not set", status));
+	if (cmd.argc == 1)
+		return (get_path_from_env(msh, "HOME",
+				"minishell: cd: HOME not set", status));
+	*status = EXIT_SUCCESS;
+	return (cmd.argv[1]);
+}
+
+static char	*get_path_from_env(
+	t_minishell *msh,
+	const char *env_name,
+	const char *error,
+	uint8_t *status
+){
+	char	*path;
+
+	path = get_env(env_name, msh);
+	if (path == NULL)
+	{
+		ft_eputendl(error);
+		*status = EXIT_FAILURE;
+		return (NULL);
+	}
+	*status = EXIT_SUCCESS;
+	return (path);
 }

src/builtins/echo/echo.c

@@ -13,7 +13,7 @@
 #include "builtins.h"
 #include "echo_def.h"
 
-u_int8_t	builtin_echo(
+uint8_t	builtin_echo(
 	t_command cmd,
 	t_minishell *msh
 ){

src/builtins/echo/echo_def.c

@@ -13,7 +13,7 @@
 #include "echo_def.h"
 
 static void		assign_flags(t_args *args, t_command cmd, size_t *i);
-static u_int8_t	is_valid_flag(t_args *args, char *flag);
+static uint8_t	is_valid_flag(t_args *args, char *flag);
 
 static void	assign_default_flags(
 	t_args *args
@@ -51,7 +51,7 @@ static void	assign_flags(
 	}
 }
 
-static u_int8_t	is_valid_flag(
+static uint8_t	is_valid_flag(
 	t_args *args,
 	char *flag
 ){

src/builtins/env/env.c

@@ -0,0 +1,58 @@
+/* ************************************************************************** */
+/*                                                                            */
+/*                                                        :::      ::::::::   */
+/*   env.c                                              :+:      :+:    :+:   */
+/*                                                    +:+ +:+         +:+     */
+/*   By: sede-san <sede-san@student.42madrid.com    +#+  +:+       +#+        */
+/*                                                +#+#+#+#+#+   +#+           */
+/*   Created: 2026/02/09 22:05:00 by codex             #+#    #+#             */
+/*   Updated: 2026/02/09 22:05:00 by codex            ###   ########.fr       */
+/*                                                                            */
+/* ************************************************************************** */
+
+#include "builtins.h"
+
+static void	print_entry(t_map_entry *entry);
+static void	print_env(t_minishell *msh);
+
+uint8_t	builtin_env(
+	t_command cmd,
+	t_minishell *msh
+)
+{
+	if (cmd.argc > 1)
+	{
+		ft_eputendl("minishell: env: too many arguments");
+		return (EXIT_FAILURE);
+	}
+	print_env(msh);
+	return (EXIT_SUCCESS);
+}
+
+static void	print_entry(
+	t_map_entry *entry
+)
+{
+	ft_putstr(entry->key);
+	ft_putchar('=');
+	if (entry->value != NULL)
+		ft_putstr(entry->value);
+	ft_putchar('\n');
+}
+
+static void	print_env(
+	t_minishell *msh
+)
+{
+	t_list	*entries;
+	t_list	*current;
+
+	entries = ft_hashmap_entries(msh->variables.environment);
+	current = entries;
+	while (current != NULL)
+	{
+		print_entry((t_map_entry *)current->content);
+		current = current->next;
+	}
+	ft_lstclear_nodes(&entries);
+}

src/builtins/exit/exit.c

@@ -11,7 +11,19 @@
 /* ************************************************************************** */
 
 #include "builtins.h"
-#include <stdint.h>
+#include <limits.h>
+
+static uint8_t	get_uint8_from_num(const char *arg, uint8_t *status);
+static uint8_t	has_overflow(
+					uint64_t n,
+					char digit,
+					uint64_t limit
+					);
+static uint8_t	resolve_exit_status(
+					t_command cmd,
+					t_minishell *msh,
+					uint8_t *exit_status
+					);
 
 uint8_t	builtin_exit(
 	t_command cmd,
@@ -19,28 +31,78 @@ uint8_t	builtin_exit(
 )
 {
 	uint8_t	exit_status;
-	
-	ft_eputendl("exit");
-	if (cmd.argc == 1)
-		exit_status = msh->exit_status;
-	else if (!ft_strisnum(cmd.argv[1]))
-	{
-		ft_eprintf(
-			"minishell: exit: %s: numeric argument required\n",
-			cmd.argv[1]);
-		return (2);
-	}
-	else if (cmd.argc > 2)
-	{
-		ft_eputendl("exit: too many arguments");
-		return (2);
-	}
-	else
-		exit_status = (uint8_t)ft_atol(cmd.argv[1]);
 
-	printf("builtin_exit: exit_status=%d\n", exit_status); // Debug print
-
-	msh->exit = 1;
+	if (isatty(STDIN_FILENO))
+		ft_eputendl("exit");
+	if (!resolve_exit_status(cmd, msh, &exit_status))
+		return (msh->exit_status);
+	msh->exit = true;
 	msh->exit_status = exit_status;
 	return (exit_status);
 }
+
+static uint8_t	resolve_exit_status(
+	t_command cmd,
+	t_minishell *msh,
+	uint8_t *exit_status
+){
+	if (cmd.argc == 1)
+		*exit_status = msh->exit_status;
+	else if (!get_uint8_from_num(cmd.argv[1], exit_status))
+	{
+		ft_eprintf("minishell: exit: %s: numeric argument required\n",
+			cmd.argv[1]);
+		msh->exit = true;
+		msh->exit_status = 2;
+		return (0);
+	}
+	else if (cmd.argc > 2)
+	{
+		ft_eputendl("minishell: exit: too many arguments");
+		msh->exit_status = EXIT_FAILURE;
+		return (0);
+	}
+	return (1);
+}
+
+static uint8_t	get_uint8_from_num(
+	const char *arg,
+	uint8_t *status
+){
+	uint64_t	n;
+	uint64_t	limit;
+	int			sign;
+
+	if (arg == NULL || *arg == '\0')
+		return (0);
+	n = 0;
+	sign = 1;
+	if (*arg == '+' || *arg == '-')
+		if (*arg++ == '-')
+			sign = -1;
+	if (*arg == '\0')
+		return (0);
+	limit = LONG_MAX;
+	if (sign == -1)
+		limit = (uint64_t)LONG_MAX + 1;
+	while (*arg != '\0')
+	{
+		if (!ft_isdigit(*arg) || has_overflow(n, *arg, limit))
+			return (0);
+		n = (n * 10) + (*arg++ - '0');
+	}
+	*status = (uint8_t)(n * sign);
+	return (1);
+}
+
+static uint8_t	has_overflow(
+	uint64_t n,
+	char digit,
+	uint64_t limit
+){
+	if (n > (limit / 10))
+		return (1);
+	if (n == (limit / 10) && (uint64_t)(digit - '0') > (limit % 10))
+		return (1);
+	return (0);
+}

src/builtins/export/export.c

@@ -0,0 +1,79 @@
+/* ************************************************************************** */
+/*                                                                            */
+/*                                                        :::      ::::::::   */
+/*   export.c                                           :+:      :+:    :+:   */
+/*                                                    +:+ +:+         +:+     */
+/*   By: sede-san <sede-san@student.42madrid.com    +#+  +:+       +#+        */
+/*                                                +#+#+#+#+#+   +#+           */
+/*   Created: 2026/02/09 22:05:00 by codex             #+#    #+#             */
+/*   Updated: 2026/02/09 22:05:00 by codex            ###   ########.fr       */
+/*                                                                            */
+/* ************************************************************************** */
+
+#include "builtins.h"
+
+static uint8_t	is_valid_identifier(const char *arg, size_t name_len);
+static uint8_t	export_one(char *arg, t_minishell *msh);
+
+uint8_t	builtin_export(
+	t_command cmd,
+	t_minishell *msh
+)
+{
+	uint8_t	status;
+	size_t	i;
+
+	if (cmd.argc == 1)
+		return (builtin_env(cmd, msh));
+	status = EXIT_SUCCESS;
+	i = 0;
+	while (cmd.argv[++i] != NULL)
+		if (export_one(cmd.argv[i], msh) != EXIT_SUCCESS)
+			status = EXIT_FAILURE;
+	return (status);
+}
+
+static uint8_t	is_valid_identifier(
+	const char *arg,
+	size_t name_len
+)
+{
+	size_t	i;
+
+	if (name_len == 0 || arg == NULL)
+		return (0);
+	if (!ft_isalpha(arg[0]) && arg[0] != '_')
+		return (0);
+	i = 0;
+	while (++i < name_len)
+		if (!ft_isalnum(arg[i]) && arg[i] != '_')
+			return (0);
+	return (1);
+}
+
+static uint8_t	export_one(
+	char *arg,
+	t_minishell *msh
+)
+{
+	char	*eq_pos;
+	char	*name;
+	size_t	name_len;
+
+	eq_pos = ft_strchr(arg, '=');
+	name_len = ft_strlen(arg);
+	if (eq_pos != NULL)
+		name_len = (size_t)(eq_pos - arg);
+	if (!is_valid_identifier(arg, name_len))
+		return (ft_eprintf("minishell: export: `%s': not a valid identifier\n",
+				arg), EXIT_FAILURE);
+	name = ft_substr(arg, 0, name_len);
+	if (name == NULL)
+		return (EXIT_FAILURE);
+	if (eq_pos != NULL)
+		set_env(name, eq_pos + 1, msh);
+	else
+		set_env(name, "", msh);
+	free(name);
+	return (EXIT_SUCCESS);
+}

src/builtins/pwd/pwd.c

@@ -12,15 +12,21 @@
 
 #include "builtins.h"
 
-u_int8_t	builtin_pwd(
+uint8_t	builtin_pwd(
 	t_command cmd,
 	t_minishell *msh
 ){
-	char	cwd[PATH_MAX];
+	char	*cwd;
 
 	(void)cmd;
 	(void)msh;
-	if (getcwd(cwd, PATH_MAX) != NULL)
-		ft_putendl(cwd);
+	cwd = getcwd(NULL, 0);
+	if (cwd == NULL)
+	{
+		perror("minishell: pwd");
+		return (EXIT_FAILURE);
+	}
+	ft_putendl(cwd);
+	free(cwd);
 	return (EXIT_SUCCESS);
 }

src/builtins/unset/unset.c

@@ -0,0 +1,61 @@
+/* ************************************************************************** */
+/*                                                                            */
+/*                                                        :::      ::::::::   */
+/*   unset.c                                            :+:      :+:    :+:   */
+/*                                                    +:+ +:+         +:+     */
+/*   By: sede-san <sede-san@student.42madrid.com    +#+  +:+       +#+        */
+/*                                                +#+#+#+#+#+   +#+           */
+/*   Created: 2026/02/09 22:05:00 by codex             #+#    #+#             */
+/*   Updated: 2026/02/09 22:05:00 by codex            ###   ########.fr       */
+/*                                                                            */
+/* ************************************************************************** */
+
+#include "builtins.h"
+
+static uint8_t	is_valid_identifier(const char *arg);
+static uint8_t	unset_one(char *arg, t_minishell *msh);
+
+uint8_t	builtin_unset(
+	t_command cmd,
+	t_minishell *msh
+)
+{
+	uint8_t	status;
+	size_t	i;
+
+	status = EXIT_SUCCESS;
+	i = 0;
+	while (cmd.argv[++i] != NULL)
+		if (unset_one(cmd.argv[i], msh) != EXIT_SUCCESS)
+			status = EXIT_FAILURE;
+	return (status);
+}
+
+static uint8_t	is_valid_identifier(
+	const char *arg
+)
+{
+	size_t	i;
+
+	if (arg == NULL || *arg == '\0')
+		return (0);
+	if (!ft_isalpha(arg[0]) && arg[0] != '_')
+		return (0);
+	i = 0;
+	while (arg[++i] != '\0')
+		if (!ft_isalnum(arg[i]) && arg[i] != '_')
+			return (0);
+	return (1);
+}
+
+static uint8_t	unset_one(
+	char *arg,
+	t_minishell *msh
+)
+{
+	if (!is_valid_identifier(arg))
+		return (ft_eprintf("minishell: unset: `%s': not a valid identifier\n",
+				arg), EXIT_FAILURE);
+	unset_env(arg, msh);
+	return (EXIT_SUCCESS);
+}

src/variables/environment.c

@@ -118,7 +118,9 @@ char	**get_envp(
 	size_t		i;
 
 	env_list = ft_hashmap_entries(msh->variables.environment);
-	envp = (char **)malloc((msh->variables.environment->size + 1) * sizeof(char *));
+	envp = (char **)malloc(
+			(msh->variables.environment->size + 1) * sizeof(char *)
+			);
 	if (envp != NULL)
 	{
 		i = 0;

src/variables/environment_unset.c

@@ -0,0 +1,41 @@
+/* ************************************************************************** */
+/*                                                                            */
+/*                                                        :::      ::::::::   */
+/*   environment_unset.c                                :+:      :+:    :+:   */
+/*                                                    +:+ +:+         +:+     */
+/*   By: sede-san <sede-san@student.42madrid.com    +#+  +:+       +#+        */
+/*                                                +#+#+#+#+#+   +#+           */
+/*   Created: 2026/02/09 22:16:00 by codex             #+#    #+#             */
+/*   Updated: 2026/02/09 22:16:00 by codex            ###   ########.fr       */
+/*                                                                            */
+/* ************************************************************************** */
+
+#include "minishell.h"
+#include "core.h"
+
+void	unset_env(
+	const char *env_name,
+	t_minishell *msh
+){
+	t_hashmap	*new_env;
+	t_list		*entries;
+	t_list		*current;
+	t_map_entry	*entry;
+
+	new_env = ft_hashmap_new(32, ft_hashmap_hashstr, ft_hashmap_strcmp);
+	if (new_env == NULL)
+		return ;
+	entries = ft_hashmap_entries(msh->variables.environment);
+	current = entries;
+	while (current != NULL)
+	{
+		entry = current->content;
+		if (ft_strcmp(entry->key, env_name) != 0)
+			ft_hashmap_put(new_env,
+				ft_strdup(entry->key), ft_strdup(entry->value));
+		current = current->next;
+	}
+	ft_lstclear_nodes(&entries);
+	ft_hashmap_clear(&msh->variables.environment, free);
+	msh->variables.environment = new_env;
+}